Skip to content

Add test for ErrorMapper #942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 6, 2024
Merged

Add test for ErrorMapper #942

merged 3 commits into from
Nov 6, 2024

Conversation

bowenxia
Copy link
Member

@bowenxia bowenxia commented Nov 5, 2024

What changed?
Add test for ErrorMapper

Why?
Code coverage week

How did you test it?
unit test

Potential risks

Release notes

Documentation Changes

@codecov Codecov
Copy link

codecov bot commented Nov 5, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.29%. Comparing base (aa86d2a) to head (3136187).
Report is 2 commits behind head on master.

Additional details and impacted files

see 4 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa86d2a...3136187. Read the comment docs.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2613

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.2%) to 78.31%
Files with Coverage Reduction New Missed Lines %
src/main/java/com/uber/cadence/internal/sync/CancellationScopeImpl.java 1 92.65%
Totals Coverage Status
Change from base Build 2612: 0.2%
Covered Lines: 15182
Relevant Lines: 19387
💛 - Coveralls

@bowenxia bowenxia merged commit 5a908a5 into master Nov 6, 2024
14 checks passed
@bowenxia bowenxia deleted the xbowen/ErrorMapperTest_00 branch November 6, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@timl3136 timl3136 timl3136 approved these changes

@Groxx Groxx Awaiting requested review from Groxx Groxx is a code owner

@abhishekj720 abhishekj720 Awaiting requested review from abhishekj720 abhishekj720 is a code owner

@natemort natemort Awaiting requested review from natemort natemort is a code owner

@shijiesheng shijiesheng Awaiting requested review from shijiesheng shijiesheng is a code owner

@dkrotx dkrotx Awaiting requested review from dkrotx dkrotx is a code owner

@taylanisikdemir taylanisikdemir Awaiting requested review from taylanisikdemir taylanisikdemir is a code owner

@demirkayaender demirkayaender Awaiting requested review from demirkayaender demirkayaender is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bowenxia @coveralls @timl3136